[
https://issues.apache.org/jira/browse/AIRFLOW-4115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795436#comment-16795436
]
ASF GitHub Bot commented on AIRFLOW-4115:
-----------------------------------------
potiuk commented on pull request #4936: [AIRFLOW-4115] Multi-staging Aiflow
Docker image with linting
URL: https://github.com/apache/airflow/pull/4936
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW-4115)
- It is sub-task of the "Parent" JIRA task
https://issues.apache.org/jira/browse/AIRFLOW-3718
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
This is the first step in implementing Multi-stage Docker image and use it
in CI tests.
Note that due to GPL licence of hadolint we might ask for exemption of ASF
to use it.
More details here:
-
https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-10+Multi-layered+and+multi-stage+official+Airflow+image
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
* automated lint on the Dockerfile run on Travis CI
The original Docker file did not have tests. Tests are coming as part of the
follow-up changes where all automated tests of Airflow will be run using the
staged image.
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
No documentation needed for that change. Design is documented in
https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-10+Multi-layered+and+multi-stage+official+Airflow+image
Follow up documentation will be added in Simplified Development Workflow
change: https://github.com/apache/airflow/pull/4932
### Code Quality
- [ ] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Docker file for Main airflow image is multi-staging and has multiple layers
> ---------------------------------------------------------------------------
>
> Key: AIRFLOW-4115
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4115
> Project: Apache Airflow
> Issue Type: Sub-task
> Reporter: Jarek Potiuk
> Priority: Major
>
> This is the first sub-task of AIRFLOW-3718 that converts existing
> mono-layered Dockerfile into multi-layered one. It will later be possible to
> add CI stage and run tests on Travis CI with the image.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
