kaxil commented on pull request #12308: URL: https://github.com/apache/airflow/pull/12308#issuecomment-727209902
https://github.com/apache/airflow/pull/12308/checks?check_run_id=1399669598#step:6:1249 ``` FAILED tests/plugins/test_plugins_manager.py::TestPluginsManager::test_should_load_plugins_from_property FAILED tests/plugins/test_plugins_manager.py::TestPluginsManager::test_should_warning_about_incompatible_plugins ======= 2 failed, 368 passed, 8 skipped, 2 warnings in 203.14s (0:03:23) ======= ``` ``` =================================== FAILURES =================================== __________ TestPluginsManager.test_should_load_plugins_from_property ___________ self = <tests.plugins.test_plugins_manager.TestPluginsManager object at 0x7efdc0b1c890> caplog = <_pytest.logging.LogCaptureFixture object at 0x7efdc0a27d50> def test_should_load_plugins_from_property(self, caplog): class AirflowTestPropertyPlugin(AirflowPlugin): name = "test_property_plugin" @property def hooks(self): class TestPropertyHook(BaseHook): pass return [TestPropertyHook] with mock_plugin_manager(plugins=[AirflowTestPropertyPlugin()]): from airflow import plugins_manager plugins_manager.ensure_plugins_loaded() assert 'AirflowTestPropertyPlugin' in str(plugins_manager.plugins) assert 'TestPropertyHook' in str(plugins_manager.registered_hooks) > assert caplog.records[0].levelname == 'INFO' E IndexError: list index out of range tests/plugins/test_plugins_manager.py:135: IndexError ----------------------------- Captured stdout call ----------------------------- [2020-11-14 11:18:08,276] {{plugins_manager.py:282}} INFO - Loading 1 plugin(s) took 0.00 seconds ______ TestPluginsManager.test_should_warning_about_incompatible_plugins _______ self = <tests.plugins.test_plugins_manager.TestPluginsManager object at 0x7efdc0a8b310> caplog = <_pytest.logging.LogCaptureFixture object at 0x7efdc0a8b910> def test_should_warning_about_incompatible_plugins(self, caplog): class AirflowAdminViewsPlugin(AirflowPlugin): name = "test_admin_views_plugin" admin_views = [mock.MagicMock()] class AirflowAdminMenuLinksPlugin(AirflowPlugin): name = "test_menu_links_plugin" menu_links = [mock.MagicMock()] with mock_plugin_manager( plugins=[AirflowAdminViewsPlugin(), AirflowAdminMenuLinksPlugin()] ), caplog.at_level(logging.WARNING): from airflow import plugins_manager plugins_manager.initialize_web_ui_plugins() > assert caplog.record_tuples == [ ( "airflow.plugins_manager", logging.WARNING, "Plugin 'test_admin_views_plugin' may not be compatible with the current Airflow version. " "Please contact the author of the plugin.", ), ( "airflow.plugins_manager", logging.WARNING, "Plugin 'test_menu_links_plugin' may not be compatible with the current Airflow version. " "Please contact the author of the plugin.", ), ] E assert [] == [('airflow.pl...the plugin.")] E Right contains 2 more items, first extra item: ('airflow.plugins_manager', 30, "Plugin 'test_admin_views_plugin' may not be compatible with the current Airflow version. Please contact the author of the plugin.") E Use -v to get the full diff tests/plugins/test_plugins_manager.py:156: AssertionError ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
