dsynkov opened a new pull request #12389:
URL: https://github.com/apache/airflow/pull/12389


   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   Fixes a bug in the `S3KeySensor` that prevents the use of Jinja-templated 
strings as arguments to `bucket_key` and `bucket_name` by performing a URL 
parsing validation in the constructor (_before_ the template gets rendered).
   
   This PR simply moves this validation downstream to the `poke` method. This 
unblocks users from using Jinja-templated fields in args to the operator.
   
   To the best of my knowledge there is no corresponding issue in Github but I 
have linked the Jira issue.
   
   closes: https://issues.apache.org/jira/browse/AIRFLOW-5115
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to