houqp commented on a change in pull request #10917:
URL: https://github.com/apache/airflow/pull/10917#discussion_r524922127



##########
File path: airflow/cli/cli_parser.py
##########
@@ -396,6 +396,7 @@ def positive_int(value):
     ("--ship-dag",), help="Pickles (serializes) the DAG and ships it to the 
worker", action="store_true"
 )
 ARG_PICKLE = Arg(("-p", "--pickle"), help="Serialized pickle object of the 
entire dag (used internally)")
+ARG_EXCEPTION_FILE = Arg(("--error-file",), help="File to store task failure 
error")

Review comment:
       i initially stated with exception, then I noticed it is named as error 
as in `taskinstance.handle_failure` and it's type could be a str or exception 
:( so i used error everywhere to be consistent with the type. I think error 
would be more accurate where, but let me know if you still prefer exception.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to