ashb commented on a change in pull request #12384:
URL: https://github.com/apache/airflow/pull/12384#discussion_r525017261
##########
File path: dev/provider_packages/refactor_provider_packages.py
##########
@@ -146,6 +146,13 @@ def rename_deprecated_modules(self) -> None:
for new, old in changes:
self.qry.select_module(new).rename(old)
+ def is_not_k8spodop(node: LN, capture: Capture, filename: Filename) ->
bool:
+ return not filename.endswith("/kubernetes_pod.py")
+
+
self.qry.select_module("airflow.providers.cncf.kubernetes.backcompat").filter(
+ callback=is_not_k8spodop
+ ).rename("airflow.kubernetes")
Review comment:
Yeah, pip doesn't really care if two distributions install the same file
-- it'll just happily overwrite the existing file.
Which is fine right until you come to uninstall things.
This brings up an interesting point. What is the behaviour when upgrading
from 1.10.x with backport provider to 2.0.0 with normal provider. Yes pip will
complain about version conflicts, but that still isn't an error (especially
given many people will be on an older pip still)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
