ashb commented on a change in pull request #12384:
URL: https://github.com/apache/airflow/pull/12384#discussion_r525080921
##########
File path: airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py
##########
@@ -208,11 +221,15 @@ def __init__( # pylint:
disable=too-many-arguments,too-many-locals
self.arguments = arguments or []
self.labels = labels or {}
self.startup_timeout_seconds = startup_timeout_seconds
- self.env_vars = env_vars or []
+ self.env_vars = convert_env_vars(env_vars) if env_vars else []
+ if pod_runtime_info_envs:
+ self.env_vars.extend([convert_pod_runtime_info_env(p) for p in
pod_runtime_info_envs])
self.env_from = env_from or []
- self.ports = ports or []
- self.volume_mounts = volume_mounts or []
- self.volumes = volumes or []
+ if configmaps:
+ self.env_from.extend([convert_configmap(c) for c in configmaps])
+ self.ports = [convert_port(p) for p in ports] if ports else []
+ self.volume_mounts = [convert_volume_mount(v) for v in volume_mounts]
if volume_mounts else []
+ self.volumes = [convert_volume(volume) for volume in volumes] if
volumes else []
Review comment:
These won't issue deprecation warnings, but that's okay because the
imports will, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
