dimberman commented on a change in pull request #12384: URL: https://github.com/apache/airflow/pull/12384#discussion_r525249266
########## File path: airflow/providers/cncf/kubernetes/backcompat/backwards_compat_converters.py ########## @@ -0,0 +1,123 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Executes task in a Kubernetes POD""" + +from typing import List + +from kubernetes.client import models as k8s + +from airflow.exceptions import AirflowException +from airflow.providers.cncf.kubernetes.backcompat.pod import Port, Resources +from airflow.providers.cncf.kubernetes.backcompat.pod_runtime_info_env import PodRuntimeInfoEnv +from airflow.providers.cncf.kubernetes.backcompat.volume import Volume +from airflow.providers.cncf.kubernetes.backcompat.volume_mount import VolumeMount + + +def _convert_kube_model_object(obj, old_class, new_class): + convert_op = getattr(obj, "to_k8s_client_obj", None) + if callable(convert_op): + return obj.to_k8s_client_obj() + elif isinstance(obj, new_class): + return obj + else: + raise AirflowException(f"Expected {old_class} or {new_class}, got {type(obj)}") + + +def convert_volume(volume) -> k8s.V1Volume: + """ + Converts an airflow Volume object into a k8s.V1Volume + @param volume: + @return: k8s.V1Volume + """ + return _convert_kube_model_object(volume, Volume, k8s.V1Volume) + + +def convert_volume_mount(volume_mount) -> k8s.V1VolumeMount: + """ + Converts an airflow VolumeMount object into a k8s.V1VolumeMount + @param volume_mount: + @return: k8s.V1VolumeMount Review comment: Is there a setting on black we can create for this or some form of a static check that automatically fixes this? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
