potiuk commented on pull request #12417: URL: https://github.com/apache/airflow/pull/12417#issuecomment-729232021
I had a quick look before going to bed - and there is nothing that I would not like in this change @ashb :). As long as all the cases we had (installing locally, installing via Github llnk, installing via PyPI) work - this is all fine. There are a few (or maybe just one - INSTALL_REQUIREMENTS order - check_install_and_setup_requires in `pre_commit_check_order_setup.py` ) static check/pre-commit that you will find that need updating. I think that's all - but we should also carefully look at the artifacts generated by the PR to be sure of that (especially whether the docker images built contain all providers and whether the provider packages have the right dependencies etc. Nothing controversial in this PR really :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
