ashb commented on a change in pull request #12463:
URL: https://github.com/apache/airflow/pull/12463#discussion_r526438414
##########
File path: tests/api_connexion/endpoints/test_dag_endpoint.py
##########
@@ -110,22 +115,21 @@ def test_should_respond_200(self):
self._create_dag_models(1)
response = self.client.get("/api/v1/dags/TEST_DAG_1",
environ_overrides={'REMOTE_USER': "test"})
assert response.status_code == 200
-
- current_response = response.json
- current_response["fileloc"] = "/tmp/test-dag.py"
+ file_token = SERIALIZER.dumps("/tmp/dag_1.py")
Review comment:
This is going to be constant as long as the secret key is constant,
right? (And that is defined in our test config). So could we include the actual
result once in one test, to ensure that it is actually encoding it correctly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
