[GitHub] [airflow] ashb commented on issue #12318: SSHOperator does support only RSA keys and should support other keys compatible with Paramiko

[GitBox]

ashb commented on issue #12318:
URL: https://github.com/apache/airflow/issues/12318#issuecomment-729997941


   This is what Paramiko does when passed a `key_filename`
   
https://github.com/paramiko/paramiko/blob/dccc563c3a581a14ceaa261b5fe0d08539f84b87/paramiko/client.py#L673-L687
   
   ```python
               for key_filename in key_filenames:
                   for pkey_class in (RSAKey, DSSKey, ECDSAKey, Ed25519Key):
                       try:
                           key = self._key_from_filepath(
                               key_filename, pkey_class, passphrase
                           )
                           allowed_types = set(
                               self._transport.auth_publickey(username, key)
                           )
                           two_factor = allowed_types & two_factor_types
                           if not two_factor:
                               return
                           break
                       except SSHException as e:
                           saved_exception = e
   ```
   
   Perhaps we could do something similar.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org