ashb commented on a change in pull request #12466:
URL: https://github.com/apache/airflow/pull/12466#discussion_r526782670
##########
File path: airflow/providers/apache/cassandra/provider.yaml
##########
@@ -33,10 +35,15 @@ integrations:
sensors:
- integration-name: Apache Cassandra
python-modules:
- - airflow.providers.apache.cassandra.sensors.record
- - airflow.providers.apache.cassandra.sensors.table
+ - .sensors.record
+ - .sensors.table
hooks:
- integration-name: Apache Cassandra
python-modules:
- - airflow.providers.apache.cassandra.hooks.cassandra
+ - .hooks.cassandra
+
+connections:
+ - connection-type: cassandra
+ hook-class: .hooks.cassandra.CassandraHook
+ connection-id-parameter-name: cassandra_conn_id
Review comment:
I'd rather we defined these as properties in code than in a yaml file
```suggestion
connections:
- hook-class: .hooks.cassandra.CassandraHook
```
And then:
```python
class CassandraHook(BaseHook):
CONNECTION_TYPE="cassandra"
CONNECTION_ID_PARAM_NAME="cassanrda_conn_id"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
