turbaszek commented on a change in pull request #12495:
URL: https://github.com/apache/airflow/pull/12495#discussion_r527673269
##########
File path: airflow/www/views.py
##########
@@ -471,8 +471,9 @@ def chart_data(self):
df = hook.get_pandas_df(
wwwutils.limit_sql(sql, CHART_LIMIT, conn_type=db.conn_type))
df = df.fillna(0)
- except Exception as e:
- payload['error'] += "SQL execution failed. Details: " + str(e)
+ except Exception:
+ log.exception("Chart SQL execution failed")
+ payload['error'] += "SQL execution failed. Contact your System
Administrator for more details"
Review comment:
Shoul we propagate the exception to users?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
