turbaszek commented on a change in pull request #12548:
URL: https://github.com/apache/airflow/pull/12548#discussion_r528338358
##########
File path: setup.py
##########
@@ -774,24 +771,28 @@ def write_version(filename: str = os.path.join(*[my_dir,
"airflow", "git_version
'zendesk': ["zendesk"],
}
-
-# Make devel_all contain all providers + extras + unique
-devel_all = list(
+# All "users" extras (no devel extras)
+all_ = list(
set(
- devel
- + [req for req_list in EXTRAS_REQUIREMENTS.values() for req in
req_list]
+ [req for req_list in EXTRAS_REQUIREMENTS.values() for req in req_list]
+ [req for req_list in PROVIDERS_REQUIREMENTS.values() for req in
req_list]
)
)
+EXTRAS_REQUIREMENTS.update({"all": all_})
-PACKAGES_EXCLUDED_FOR_ALL = []
+# Development extras
+EXTRAS_REQUIREMENTS.update(
+ {
+ 'devel': devel_minreq, # includes doc
+ 'devel_hadoop': devel_hadoop, # includes devel_minreq
+ 'doc': doc,
+ }
+)
+# This can be simplify to devel_hadoop + all_ due to inclusions
+# but we keep it for explicit sake
+devel_all = list(set(all_ + doc + devel_minreq + devel_hadoop))
-if PY3:
- PACKAGES_EXCLUDED_FOR_ALL.extend(
- [
- 'snakebite',
- ]
- )
Review comment:
For 2.0 we are using only Py3+ so the if is always true. Moreover
there's no `snakebite` requirement in any extra.
##########
File path: setup.py
##########
@@ -811,11 +812,6 @@ def is_package_excluded(package: str, exclusion_list:
List[str]):
return any(package.startswith(excluded_package) for excluded_package in
exclusion_list)
-devel_all = [
- package
- for package in devel_all
- if not is_package_excluded(package=package,
exclusion_list=PACKAGES_EXCLUDED_FOR_ALL)
-]
Review comment:
If we remove the "snakebite if" then `PACKAGES_EXCLUDED_FOR_ALL` is
empty so this line do no changes, so we should probably remove it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
