potiuk commented on pull request #12512:
URL: https://github.com/apache/airflow/pull/12512#issuecomment-732147934


   > Looking good.
   > 
   > I'm not quite convinced by the need to make everything quite so private -- 
it's not really a common pattern in Airflow, and by making some things public 
it lets users use this class too.
   
   I can change it to protected no problem.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to