XD-DENG opened a new pull request #12573: URL: https://github.com/apache/airflow/pull/12573
https://github.com/apache/airflow/pull/9067 made `conn_id` unique, and this is effective from 2.0.*. Due to this change, `BaseHook.get_connections()` will return a List of length 1, or raise Exception. In such a case, we should simply always get the only element from the output, and drop `random.choice()` in `BaseHook.get_connection()`, which was only applicable for the earlier setting (multiple connections is allowed for single `conn_id`, which is no longer true). ### A Side Question After https://github.com/apache/airflow/pull/9067 is rolled out, I would question if we still need `hook.get_connections()` (note NOT `get_connection()`). This needs change in bigger scope and may be a breaking change for many users. So I'm not addressing/touching it in this PR. <!-- Thank you for contributing! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! In case of existing issue, reference it using one of the following: closes: #ISSUE related: #ISSUE How to write a good git commit message: http://chris.beams.io/posts/git-commit/ --> --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information. In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
