turbaszek commented on a change in pull request #12574:
URL: https://github.com/apache/airflow/pull/12574#discussion_r528967901
##########
File path: airflow/sensors/external_task_sensor.py
##########
@@ -149,38 +148,22 @@ def poke(self, context, session=None):
dttm = context['execution_date']
dttm_filter = dttm if isinstance(dttm, list) else [dttm]
Review comment:
Btw. this is something that bothers me. We "believe" in operator
atomicity but this functionality allows users to provide a function that
returns a list of dates. If list is provided then we query not for single
DAG/task but for multiple ones.
But users will get 1/0 response - task/dag failed. there will be not
information how many instances failed or for which dates. I think that the
proper Airflow approach would be to have multiple sensors each checking single
exec date.
@kaxil @XD-DENG WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
