houqp commented on a change in pull request #12530:
URL: https://github.com/apache/airflow/pull/12530#discussion_r528982217
##########
File path: airflow/models/baseoperator.py
##########
@@ -1336,6 +1336,9 @@ def get_extra_links(self, dttm: datetime, link_name: str)
-> Optional[Dict[str,
def get_serialized_fields(cls):
"""Stringified DAGs and operators contain exactly these fields."""
if not cls.__serialized_fields:
+ from airflow.models.dag import DagContext
+
+ DagContext.push_context_managed_dag(None)
Review comment:
Depends on how you use the context manager. `with DAG():` works as
expected, but we have huge DAGs (> 9K loc) in production that would be a lot
easier to maintain without that extra indentation introduced with the `with`
block. So we are using `DagContext.push_context_managed_dag(dag)` directly in
the DAG definition. This is what triggered the crash.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
