ashb commented on a change in pull request #12158:
URL: https://github.com/apache/airflow/pull/12158#discussion_r529438705
##########
File path: airflow/stats.py
##########
@@ -30,6 +31,245 @@
log = logging.getLogger(__name__)
+class MetricType(str, enum.Enum):
+ """Metrics types."""
+
+ COUNTER = "COUNTER"
+ GAUGE = "GAUGE"
+ TIMER = "TIMER"
+
+
+class Metric(NamedTuple):
+ """StatsD metrics definition"""
+
+ metric_type: str
+ key: str
+ description: str
+
+
+METRICS_LIST: List[Metric] = [
Review comment:
I'm not sure the purpose of this List, nor the Metric class -- it
appears this is never used for emitting metrics at runtime, so I'm not sure why
we need this?
What was your thinking here please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
