marcusianlevine commented on pull request #11509:
URL: https://github.com/apache/airflow/pull/11509#issuecomment-733078360


   Thanks for looking into this @potiuk - I just confirmed that I do indeed 
have the correct version installed (these commands were run inside my 
webserver's Docker container):
   
   ```
   $ pip list | grep elasticsearch
   apache-airflow-backport-providers-elasticsearch 2020.11.13
   ```
   
   I confirmed as well that, as before, the import in 
`/usr/local/lib/python3.7/site-packages/airflow/providers/elasticsearch` has 
not been modified:
   
   ```
   $ cat 
/usr/local/lib/python3.7/site-packages/airflow/providers/elasticsearch/log/es_task_handler.py
  | grep FileTask
   from airflow.utils.log.file_task_handler import FileTaskHandler
   class ElasticsearchTaskHandler(FileTaskHandler, LoggingMixin):
   ```
   
   What's peculiar is that the copied version of the `file_task_handler` module 
is present inside the provider at the correct location:
   ```
   $ ls 
/usr/local/lib/python3.7/site-packages/airflow/providers/elasticsearch/common/utils/log/
   __init__.py  __pycache__  file_task_handler.py
   ```
   
   Maybe I'm not understanding the backport provider structure correctly... am 
I not looking in the right place for the refactored code?
   
   As you observed, I did specify the custom logging class based on where I 
thought the backport provider class should be found 
(`airflow.providers.elasticsearch.log.es_task_handler.ElasticsearchTaskHandler`)
 but that corresponds to the file above which does not have the proper 
refactored import... 🤯 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to