hsnprsd commented on a change in pull request #12586:
URL: https://github.com/apache/airflow/pull/12586#discussion_r529749806



##########
File path: airflow/models/serialized_dag.py
##########
@@ -73,8 +73,7 @@ class SerializedDagModel(Base):
 
     dag_runs = relationship(
         DagRun,
-        primaryjoin=dag_id == DagRun.dag_id,
-        foreign_keys=dag_id,
+        primaryjoin=dag_id == foreign(DagRun.dag_id),

Review comment:
       You are right. I tested and we don't need that. I am new to Airflow and 
SQLAlchemy tbh :).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to