ashb edited a comment on issue #12602:
URL: https://github.com/apache/airflow/issues/12602#issuecomment-733628966


   Please also (somewhere) document what Airflow requires of the image being 
run.
   
   Because there are at least  three "common" images that people might run 
(airflow, puckel, astronomer) and they might all handle this differently.
   
   Astronomer:
   
https://github.com/astronomer/ap-airflow/blob/42b4169254c1e58a74ada74ce54ec27c470aeb90/2.0.0/buster/include/entrypoint#L51-L52
   
   ```bash
   # Run the original command
   exec "$@"
   ```
   
   Puckel
   
   
https://github.com/puckel/docker-airflow/blob/bed777970caa3e555ef618d84be07404438c27e3/script/entrypoint.sh#L131:
   
   ```sh
     *)
       # The command is something like bash, not an airflow subcommand. Just 
run it in the right environment.
       exec "$@"
       ;;
   ```
   
   Bitnami: 
   
   
https://github.com/bitnami/bitnami-docker-airflow-worker/blob/91495fd8eceaa9523eca9388494e8941db99e549/1/debian-10/rootfs/app-entrypoint.sh#L20
   
   ```
   exec tini -- "$@"
   ```
   
   So it actually appears that "airflow ..." is the more common form.
   
   I almost wonder if this should be a config option/something in the pod 
template.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to