ecerulm commented on a change in pull request #12619:
URL: https://github.com/apache/airflow/pull/12619#discussion_r531012827



##########
File path: chart/tests/helm_template_generator.py
##########
@@ -29,7 +29,7 @@
 
 api_client = ApiClient()
 
-BASE_URL_SPEC = 
"https://raw.githubusercontent.com/instrumenta/kubernetes-json-schema/master/v1.12.9";

Review comment:
       Ok, I've raised the prerequisite to 1.14, but I 'd like to note that was 
already a prerequisite (if you wanted to use ingresses). But now we validate 
helm chart outputs (ingresses or not) to 1.14 so it's a good idea to require 
1.14




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to