TheRook commented on a change in pull request #12638:
URL: https://github.com/apache/airflow/pull/12638#discussion_r531096151
##########
File path: airflow/operators/bash.py
##########
@@ -95,10 +101,16 @@ class BashOperator(BaseOperator):
bash_task = BashOperator(
task_id="bash_task",
- bash_command='echo "here is the message: \'$message\'"',
+ bash_command=['echo', "here is the message: \'$message\'"],
env={'message': '{{ dag_run.conf["message"] if dag_run else ""
}}'},
)
+ We also highly recommend against using [\"bash\", \"-c\"... in your
command as that command will negate
Review comment:
Perhaps we can link to some docs here? I am willing to write up a page
on injection in general, and why parallelization is a good tool for the job.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
