ecerulm commented on pull request #12634: URL: https://github.com/apache/airflow/pull/12634#issuecomment-734710314
I've been thinking about the whole ingress situation. Even after this and #12619 are merged, in order to get a working airflow ingress with a custom hostname and path in AWS EKS the following will be required * ingress.web.annotations #12607 * ingress.web.host: `www.example.com` * ingress.web.path: `/airflow/*` * config.web.server.base_url: `https://www.example.com/airflow` * webserver.livenessProbe.path: `/airflow/health` * webserver.livenessProbe.host: `www.example.com` * webserver.readinessProbe.path: `/airflow/health` * webserver.readinessProbe.host: `www.example.com` So there is lot of repetition and matching required, the hostname appears in `base_url`, `ingress.web.host` and `webserver.*.host`. The path prefix `/airflow` appear in `ingress.web.path` and `webserver.*.path`. I'm thinking to create yet another PR after the others are merged that takes `ingress.web.host` and `ingress.web.path` and fills values for `config.web.server.base_url` and `webserver.*.{path,host}`if they are not explicitly provided. Is that something that you would be interested on having? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
