potiuk commented on pull request #12188:
URL: https://github.com/apache/airflow/pull/12188#issuecomment-735216551
> Shouldn't a change to setup.py/setup.cfg be all that is needed @potiuk ?
Indeed. In this case it will not work. What @ephrain will need to do is to
add || true after pip check (because the problem is that currently production
image dependencies are still broken,
But in general case this label might be needed if you have some reason to
force dependencies to latest ones.
This works as follows:
* In PRs we do not run "eager" upgrade strategy, be default we use
"only-if-needed" strategy. This is in order to avoid new released dependencies
breaking people's PR. PRs will use the "constrained" dependencies, unless the
change in setup.py causes that those dependencies need to be upgraded because
the "constrained" dependencies are outside of the requirements.
* We only use "eager" upgrade strategy in two cases:
1) when we run direct push or schedule from master
2) when "upgrade to latest dependencies" label is set on a PR.
The first case is needed to automatically upgrade constraints to the latest
"good dependencies". If the dependencies (after eager upgrade) are
non-conflicting (they should not be now) and if all tests passes. the
constraint file in the right branch is automatically updated with those new
constraints,
The second case is only needed really if you want to try to fix failing
upgrade to latest dependencies. If the 'master" build will start failing when
trying to run "eager" update, we have to have some way to add extra limitations
and test it. This is exactly where we need to set the "upgrade to latest
dependencies" label. Such PR will take the latest limitation from
setup.py/setup.cfg and run "eager" update and run all tests. This way we can
easily work on fixing failing "eager" upgrade.
I hope thise explanation makes it is clear.
I am also going to add some explanation in error messages in all those
places where upgrade with eager dependencies might fail and provide
instructions what to do in those cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
