XD-DENG commented on a change in pull request #12701:
URL: https://github.com/apache/airflow/pull/12701#discussion_r532211800
##########
File path: .github/workflows/label_when_reviewed_workflow_run.yml
##########
@@ -97,21 +97,23 @@ jobs:
require_committers_approval: 'true'
pullRequestNumber: ${{
steps.source-run-info.outputs.pullRequestNumber }}
comment: >
- The PR needs to run all tests because it modifies core of Airflow!
Please rebase it to latest
- master or ask committer to re-run it!
+ The PR most likely needs to run full matrix of tests because it
modifies parts of the core
+ of Airflow. However, committers might decide to merge it quickly
and take the risk.
+ If they don't merge it quickly - please rebase it to latest master
at your convenience,
+ or amend the last commit of the PR, and push it with
--force-with-lease.
- name: "Initiate GitHub Check forcing rerun of SH ${{
github.event.pull_request.head.sha }}"
uses:
LouisBrunner/checks-action@9f02872da71b6f558c6a6f190f925dde5e4d8798 # v1.1.0
id: full-test-check
if:
steps.label-full-test-prs-when-approved-by-commiters.outputs.labelSet == 'true'
with:
token: ${{ secrets.GITHUB_TOKEN }}
- name: "Please rebase or re-run to run full tests"
+ name: "Please rebase or amend and force push the PR to run full
tests"
Review comment:
```suggestion
name: "Please rebase or amend, and force push the PR to run full
tests"
```
##########
File path: .github/workflows/label_when_reviewed_workflow_run.yml
##########
@@ -97,21 +97,23 @@ jobs:
require_committers_approval: 'true'
pullRequestNumber: ${{
steps.source-run-info.outputs.pullRequestNumber }}
comment: >
- The PR needs to run all tests because it modifies core of Airflow!
Please rebase it to latest
- master or ask committer to re-run it!
+ The PR most likely needs to run full matrix of tests because it
modifies parts of the core
+ of Airflow. However, committers might decide to merge it quickly
and take the risk.
+ If they don't merge it quickly - please rebase it to latest master
at your convenience,
Review comment:
```suggestion
If they don't merge it quickly - please rebase it to the latest
master at your convenience,
```
nit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
