mjpieters commented on a change in pull request #12694:
URL: https://github.com/apache/airflow/pull/12694#discussion_r532213634
##########
File path: setup.cfg
##########
@@ -100,6 +100,7 @@ install_requires =
funcsigs>=1.0.0, <2.0.0
graphviz>=0.12
gunicorn>=19.5.0, <20.0
+ importlib_metadata~=1.7 # We could work with 3.1, but argparse needs <2
Review comment:
> Makes me wonder if/when we should continue to use it anyway on Py 3.8?
Your not using the 3.9 / importlib_metadata 1.6 feature: `Added module and
attr attributes to EntryPoint`; everything else is bug fixing or perf
improvements, which all have been backported to 3.8.
Even if you _were_ using those extra attributes, using
`python_version<="3.8"` (and inverting the import guard) would be a good idea
to keep the dependencies flexible and avoid limiting what packages people can
use with Airflow.
I don't see where `virtualenv` depends on importlib_metadata? Nor does
pylint depend on virtualenv. Might be in older versions. `pre-commit` depends
on virtualenv though. And jsonlint depends on `importlib_metadata` but sets no
pin.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
