potiuk commented on a change in pull request #12703:
URL: https://github.com/apache/airflow/pull/12703#discussion_r532238530
##########
File path: setup.cfg
##########
@@ -100,8 +100,8 @@ install_requires =
funcsigs>=1.0.0, <2.0.0
graphviz>=0.12
gunicorn>=19.5.0, <20.0
- importlib_metadata~=1.7 # We could work with 3.1, but argparse needs <2
- importlib_resources~=1.4
+ importlib_metadata>=1.5,<4;python_version<="3.7"
Review comment:
Also. The problem might be that in our process (in master merges) we
automatically do 'pip install .[all] --upgrade --upgrade-strategy eager` to
automatically find set of latest constraints that are matching setup.py +
setup.cfg limitations, Then we run pip check and then we run all tests and if
it all passes.
As far as I remember without ~1.* for importlib_resources in
install_requires caused a problem as pip first tries to install the highest
version matching in `install_requires` only - without looking at extras. Once
it installs this version, it will only then try to do eager update on all other
extras and one of our dependencies already has importib_resources ~= 1.4. Eager
upgrade will never downgrade the packages installed by install_requires, so
this results in version conflict.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
