ashb commented on a change in pull request #4761: [AIRFLOW-3942] Expose FAB
args to plugins
URL: https://github.com/apache/airflow/pull/4761#discussion_r267727065
##########
File path: airflow/www/app.py
##########
@@ -151,15 +152,18 @@ def integrate_plugins():
for v in flask_appbuilder_views:
log.debug("Adding view %s", v["name"])
- appbuilder.add_view(v["view"],
- v["name"],
- category=v["category"])
+ if 'view' in v:
+ v['baseview'] = v.pop('view')
+ warnings.warn(
+ "AirflowPlugin.flask_appbuilder_views[]
dictionaries should use 'baseview' instead of 'view. "
Review comment:
Can we include the plugin name in this message to make it easier to track
down the plugin at fault (since we can't have the file:line of the warning come
from the plugin file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
