potiuk commented on pull request #12718: URL: https://github.com/apache/airflow/pull/12718#issuecomment-735960511
@turbaszek @kaxil @ashb @mik-laj [@mjpieters ?] -> The PR with improved PIP check is ready - and you can actually see how things will work when there is a problem with PIP check (we still have the azure problem to fix in the prod image that @ephraimbuddy is working on): https://github.com/apache/airflow/pull/12718/checks?check_run_id=1475010204#step:4:562 I already have a couple of small improvements to add: * adding RED error message to indicate clearly that the `pip check` output is an error and GREEN when everything is fine * few typos However, I would love to get some comments on the wording and instructions. I based it on my experiences with getting rid of the conflicts and how I was solving them. I think those instructions should be clear enough for the contributors and commiters on what they should do in case their change actually results in conflict so I am happy to hear any comments. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
