NadimYounes opened a new issue #12722:
URL: https://github.com/apache/airflow/issues/12722


   Hello,
   
   I have recently noticed that a lot of connections with certain special 
characters don't work with SqlAlchemy as it requires the passwords to be 
[urlencoded when they contain special 
characters](https://stackoverflow.com/questions/1423804/writing-a-connection-string-when-password-contains-special-characters).
 
   
   Would there be any impact to changing the code at line 81 to urlencode the 
password like `urllib.parse.quote_plus(conn.password)` to prevent login 
failures for special characters? 
   
   
https://github.com/apache/airflow/blob/dee304b222d355b03794aa063f39e3ee13997730/airflow/hooks/dbapi_hook.py#L81
   
   I initially caught this issue while using the OdbcHook method found here. 
https://github.com/apache/airflow/blob/dee304b222d355b03794aa063f39e3ee13997730/airflow/providers/odbc/hooks/odbc.py#L198
   
   Happy to create a feature request, I just want to confirm that this issue 
makes sense. 
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to