galuszkak commented on a change in pull request #4952:
feat/AIRFLOW-4008/k8s-executor-env-from
URL: https://github.com/apache/airflow/pull/4952#discussion_r267728541
##########
File path: airflow/contrib/kubernetes/worker_configuration.py
##########
@@ -331,4 +331,6 @@ def make_pod(self, namespace, worker_uuid, pod_id, dag_id,
task_id, execution_da
affinity=affinity,
tolerations=tolerations,
security_context=self._get_security_context(),
+ env_from_configmap_ref=self.kube_config.env_from_configmap_ref,
+ env_from_secret_ref=self.kube_config.env_from_secret_ref
Review comment:
As suggested in my PR (see: #4772) by @ashb this should go to `secrets` and
`configmaps`.
I had basically the same structure as You are showing here, but it was
rejected in code review of my PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
