ashb commented on a change in pull request #12735:
URL: https://github.com/apache/airflow/pull/12735#discussion_r533489981
##########
File path: breeze
##########
@@ -2800,12 +2800,12 @@ function breeze::check_and_save_all_params() {
if [[ ${PYTHON_MAJOR_MINOR_VERSION} == "2.7" ||
${PYTHON_MAJOR_MINOR_VERSION} == "3.5" ]]; then
if [[ ${BRANCH_NAME} == "master" ]]; then
- echo >&2
- echo >&2 "The ${PYTHON_MAJOR_MINOR_VERSION} can only be used when
installing Airflow 1.10.*"
- echo >&2
- echo >&2 "You can use it only when you specify 1.10 Airflow via
--install-airflow-version"
- echo >&2 "or --install-airflow-reference and they point to 1.10
version of Airflow"
- echo >&2
+ echo
+ echo -e " \e[31mERROR: The ${PYTHON_MAJOR_MINOR_VERSION} can only
be used when installing Airflow 1.10.*\e[0m"
Review comment:
I think something like this would ease readability:
```suggestion
echo " ${COLOR_RED}ERROR: The ${PYTHON_MAJOR_MINOR_VERSION} can
only be used when installing Airflow 1.10.*${COLOR_RESET}"
```
```sh
COLOR_RED=$'\e[31m'
COLOR_RESET=$'\e[0m'
# etc.
```
(Or we could try associative arrays and then `${color[red]}`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
