ashb commented on a change in pull request #4583: [AIRFLOW-3746] Fix to prevent
missing container exit
URL: https://github.com/apache/airflow/pull/4583#discussion_r267745603
##########
File path: tests/operators/test_docker_operator.py
##########
@@ -49,6 +49,7 @@ def test_execute(self, client_class_mock, mkdtemp_mock):
client_mock.create_container.return_value = {'Id': 'some_id'}
client_mock.create_host_config.return_value = host_config
client_mock.images.return_value = []
+ client_mock.attach.return_value = ['container log']
client_mock.logs.return_value = ['container log']
Review comment:
Probably don't need this mock anymore?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
