kaxil commented on a change in pull request #12704:
URL: https://github.com/apache/airflow/pull/12704#discussion_r533827933
##########
File path: tests/cli/commands/test_task_command.py
##########
@@ -55,6 +55,7 @@ def reset(dag_id):
runs.delete()
+# TODO: Check if tests needs side effects - locally there's missing DAG
Review comment:
Weird:
```
❯ ./breeze --python 3.6 --backend postgres --db-reset
===============================================================================================
Checking integrations and backends
===============================================================================================
PostgreSQL: OK.
-----------------------------------------------------------------------------------------------
-----------------------------------------------------------------------------------------------
Resetting the DB
DB: postgresql+psycopg2://postgres:***@postgres/airflow
[2020-12-02 01:05:00,245] {db.py:619} INFO - Dropping tables that exist
[2020-12-02 01:05:00,553] {migration.py:155} INFO - Context impl
PostgresqlImpl.
[2020-12-02 01:05:00,554] {migration.py:162} INFO - Will assume
transactional DDL.
[2020-12-02 01:05:00,968] {db.py:609} INFO - Creating tables
INFO [alembic.runtime.migration] Context impl PostgresqlImpl.
INFO [alembic.runtime.migration] Will assume transactional DDL.
INFO [alembic.runtime.migration] Running upgrade -> e3a246e0dc1, current
schema
INFO [alembic.runtime.migration] Running upgrade e3a246e0dc1 ->
1507a7289a2f, create is_encrypted
INFO [alembic.runtime.migration] Running upgrade 1507a7289a2f ->
13eb55f81627, maintain history for compatibility with earlier migrations
INFO [alembic.runtime.migration] Running upgrade 13eb55f81627 ->
338e90f54d61, More logging into task_instance
INFO [alembic.runtime.migration] Running upgrade 338e90f54d61 ->
52d714495f0, job_id indices
INFO [alembic.runtime.migration] Running upgrade 52d714495f0 ->
502898887f84, Adding extra to Log
INFO [alembic.runtime.migration] Running upgrade 502898887f84 ->
1b38cef5b76e, add dagrun
INFO [alembic.runtime.migration] Running upgrade 1b38cef5b76e ->
2e541a1dcfed, task_duration
INFO [alembic.runtime.migration] Running upgrade 2e541a1dcfed ->
40e67319e3a9, dagrun_config
INFO [alembic.runtime.migration] Running upgrade 40e67319e3a9 ->
561833c1c74b, add password column to user
INFO [alembic.runtime.migration] Running upgrade 561833c1c74b ->
4446e08588, dagrun start end
INFO [alembic.runtime.migration] Running upgrade 4446e08588 ->
bbc73705a13e, Add notification_sent column to sla_miss
INFO [alembic.runtime.migration] Running upgrade bbc73705a13e ->
bba5a7cfc896, Add a column to track the encryption state of the 'Extra' field
in connection
INFO [alembic.runtime.migration] Running upgrade bba5a7cfc896 ->
1968acfc09e3, add is_encrypted column to variable table
INFO [alembic.runtime.migration] Running upgrade 1968acfc09e3 ->
2e82aab8ef20, rename user table
INFO [alembic.runtime.migration] Running upgrade 2e82aab8ef20 ->
211e584da130, add TI state index
INFO [alembic.runtime.migration] Running upgrade 211e584da130 ->
64de9cddf6c9, add task fails journal table
INFO [alembic.runtime.migration] Running upgrade 64de9cddf6c9 ->
f2ca10b85618, add dag_stats table
INFO [alembic.runtime.migration] Running upgrade f2ca10b85618 ->
4addfa1236f1, Add fractional seconds to mysql tables
INFO [alembic.runtime.migration] Running upgrade 4addfa1236f1 ->
8504051e801b, xcom dag task indices
INFO [alembic.runtime.migration] Running upgrade 8504051e801b ->
5e7d17757c7a, add pid field to TaskInstance
INFO [alembic.runtime.migration] Running upgrade 5e7d17757c7a ->
127d2bf2dfa7, Add dag_id/state index on dag_run table
INFO [alembic.runtime.migration] Running upgrade 127d2bf2dfa7 ->
cc1e65623dc7, add max tries column to task instance
INFO [alembic.runtime.migration] Running upgrade cc1e65623dc7 ->
bdaa763e6c56, Make xcom value column a large binary
INFO [alembic.runtime.migration] Running upgrade bdaa763e6c56 ->
947454bf1dff, add ti job_id index
INFO [alembic.runtime.migration] Running upgrade 947454bf1dff ->
d2ae31099d61, Increase text size for MySQL (not relevant for other DBs' text
types)
INFO [alembic.runtime.migration] Running upgrade d2ae31099d61 ->
0e2a74e0fc9f, Add time zone awareness
INFO [alembic.runtime.migration] Running upgrade d2ae31099d61 ->
33ae817a1ff4, kubernetes_resource_checkpointing
INFO [alembic.runtime.migration] Running upgrade 33ae817a1ff4 ->
27c6a30d7c24, kubernetes_resource_checkpointing
INFO [alembic.runtime.migration] Running upgrade 27c6a30d7c24 ->
86770d1215c0, add kubernetes scheduler uniqueness
INFO [alembic.runtime.migration] Running upgrade 86770d1215c0, 0e2a74e0fc9f
-> 05f30312d566, merge heads
INFO [alembic.runtime.migration] Running upgrade 05f30312d566 ->
f23433877c24, fix mysql not null constraint
INFO [alembic.runtime.migration] Running upgrade f23433877c24 ->
856955da8476, fix sqlite foreign key
INFO [alembic.runtime.migration] Running upgrade 856955da8476 ->
9635ae0956e7, index-faskfail
INFO [alembic.runtime.migration] Running upgrade 9635ae0956e7 ->
dd25f486b8ea, add idx_log_dag
INFO [alembic.runtime.migration] Running upgrade dd25f486b8ea ->
bf00311e1990, add index to taskinstance
INFO [alembic.runtime.migration] Running upgrade 9635ae0956e7 ->
0a2a5b66e19d, add task_reschedule table
INFO [alembic.runtime.migration] Running upgrade 0a2a5b66e19d, bf00311e1990
-> 03bc53e68815, merge_heads_2
INFO [alembic.runtime.migration] Running upgrade 03bc53e68815 ->
41f5f12752f8, add superuser field
INFO [alembic.runtime.migration] Running upgrade 41f5f12752f8 ->
c8ffec048a3b, add fields to dag
INFO [alembic.runtime.migration] Running upgrade c8ffec048a3b ->
dd4ecb8fbee3, Add schedule interval to dag
INFO [alembic.runtime.migration] Running upgrade dd4ecb8fbee3 ->
939bb1e647c8, task reschedule fk on cascade delete
INFO [alembic.runtime.migration] Running upgrade 939bb1e647c8 ->
6e96a59344a4, Make TaskInstance.pool not nullable
INFO [alembic.runtime.migration] Running upgrade 6e96a59344a4 ->
d38e04c12aa2, add serialized_dag table
INFO [alembic.runtime.migration] Running upgrade d38e04c12aa2 ->
b3b105409875, add root_dag_id to DAG
INFO [alembic.runtime.migration] Running upgrade 6e96a59344a4 ->
74effc47d867, change datetime to datetime2(6) on MSSQL tables
INFO [alembic.runtime.migration] Running upgrade 939bb1e647c8 ->
004c1210f153, increase queue name size limit
INFO [alembic.runtime.migration] Running upgrade c8ffec048a3b ->
a56c9515abdc, Remove dag_stat table
INFO [alembic.runtime.migration] Running upgrade a56c9515abdc,
004c1210f153, 74effc47d867, b3b105409875 -> 08364691d074, Merge the four heads
back together
INFO [alembic.runtime.migration] Running upgrade 08364691d074 ->
fe461863935f, increase_length_for_connection_password
INFO [alembic.runtime.migration] Running upgrade fe461863935f ->
7939bcff74ba, Add DagTags table
INFO [alembic.runtime.migration] Running upgrade 7939bcff74ba ->
a4c2fd67d16b, add pool_slots field to task_instance
INFO [alembic.runtime.migration] Running upgrade a4c2fd67d16b ->
852ae6c715af, Add RenderedTaskInstanceFields table
INFO [alembic.runtime.migration] Running upgrade 852ae6c715af ->
952da73b5eff, add dag_code table
INFO [alembic.runtime.migration] Running upgrade 952da73b5eff ->
a66efa278eea, Add Precision to execution_date in RenderedTaskInstanceFields
table
INFO [alembic.runtime.migration] Running upgrade a66efa278eea ->
cf5dc11e79ad, drop_user_and_chart
INFO [alembic.runtime.migration] Running upgrade cf5dc11e79ad ->
bbf4a7ad0465, Remove id column from xcom
INFO [alembic.runtime.migration] Running upgrade bbf4a7ad0465 ->
b25a55525161, Increase length of pool name
INFO [alembic.runtime.migration] Running upgrade b25a55525161 ->
3c20cacc0044, Add DagRun run_type
INFO [alembic.runtime.migration] Running upgrade 3c20cacc0044 ->
8f966b9c467a, Set conn_type as non-nullable
INFO [alembic.runtime.migration] Running upgrade 8f966b9c467a ->
8d48763f6d53, add unique constraint to conn_id
INFO [alembic.runtime.migration] Running upgrade 8d48763f6d53 ->
da3f683c3a5a, Add dag_hash Column to serialized_dag table
INFO [alembic.runtime.migration] Running upgrade da3f683c3a5a ->
92c57b58940d, Create FAB Tables
INFO [alembic.runtime.migration] Running upgrade 92c57b58940d ->
03afc6b6f902, Increase length of FAB ab_view_menu.name column
INFO [alembic.runtime.migration] Running upgrade 03afc6b6f902 ->
e38be357a868, Add sensor_instance table
INFO [alembic.runtime.migration] Running upgrade e38be357a868 ->
b247b1e3d1ed, Add queued by Job ID to TI
INFO [alembic.runtime.migration] Running upgrade b247b1e3d1ed ->
e1a11ece99cc, Add external executor ID to TI
INFO [alembic.runtime.migration] Running upgrade e1a11ece99cc ->
bef4f3d11e8b, Drop KubeResourceVersion and KubeWorkerId
INFO [alembic.runtime.migration] Running upgrade bef4f3d11e8b ->
98271e7606e2, Add scheduling_decision to DagRun and DAG
INFO [alembic.runtime.migration] Running upgrade 98271e7606e2 ->
52d53670a240, fix_mssql_exec_date_rendered_task_instance_fields_for_MSSQL
INFO [alembic.runtime.migration] Running upgrade 52d53670a240 ->
364159666cbd, Add creating_job_id to DagRun table
INFO [alembic.runtime.migration] Running upgrade 364159666cbd ->
45ba3f1493b9, add-k8s-yaml-to-rendered-templates
INFO [alembic.runtime.migration] Running upgrade 45ba3f1493b9 ->
849da589634d, Prefix DAG permissions.
[2020-12-02 01:05:05,538] {manager.py:727} WARNING - No user yet created,
use flask fab command to do it.
root@34129b165f1a:/opt/airflow# pytest
tests/cli/commands/test_task_command.py::TestCliTasks
====================================================================================================================
test session starts
=====================================================================================================================
platform linux -- Python 3.6.12, pytest-6.1.2, py-1.9.0, pluggy-0.13.1 --
/usr/local/bin/python
cachedir: .pytest_cache
rootdir: /opt/airflow, configfile: pytest.ini
plugins: forked-1.3.0, timeouts-1.2.1, cov-2.10.1, celery-4.4.7,
flaky-3.7.0, xdist-2.1.0, instafail-0.4.2, requests-mock-1.8.0,
rerunfailures-9.1.1
setup timeout: 0.0s, execution timeout: 0.0s, teardown timeout: 0.0s
collected 17 items
tests/cli/commands/test_task_command.py::TestCliTasks::test_cli_list_tasks
PASSED
[ 5%]
tests/cli/commands/test_task_command.py::TestCliTasks::test_cli_run PASSED
[ 11%]
tests/cli/commands/test_task_command.py::TestCliTasks::test_cli_run_invalid_raw_option_0__ignore_all_dependencies
PASSED
[ 17%]
tests/cli/commands/test_task_command.py::TestCliTasks::test_cli_run_invalid_raw_option_1__ignore_depends_on_past
PASSED
[ 23%]
tests/cli/commands/test_task_command.py::TestCliTasks::test_cli_run_invalid_raw_option_2__ignore_dependencies
PASSED
[ 29%]
tests/cli/commands/test_task_command.py::TestCliTasks::test_cli_run_invalid_raw_option_3__force
PASSED
[ 35%]
tests/cli/commands/test_task_command.py::TestCliTasks::test_cli_run_mutually_exclusive
PASSED
[ 41%]
tests/cli/commands/test_task_command.py::TestCliTasks::test_cli_test PASSED
[ 47%]
tests/cli/commands/test_task_command.py::TestCliTasks::test_cli_test_with_env_vars
PASSED
[ 52%]
tests/cli/commands/test_task_command.py::TestCliTasks::test_cli_test_with_params
PASSED
[ 58%]
tests/cli/commands/test_task_command.py::TestCliTasks::test_local_run
SKIPPED
[ 64%]
tests/cli/commands/test_task_command.py::TestCliTasks::test_parentdag_downstream_clear
PASSED
[ 70%]
tests/cli/commands/test_task_command.py::TestCliTasks::test_run_naive_taskinstance
PASSED
[ 76%]
tests/cli/commands/test_task_command.py::TestCliTasks::test_subdag_clear
PASSED
[ 82%]
tests/cli/commands/test_task_command.py::TestCliTasks::test_task_state
PASSED
[ 88%]
tests/cli/commands/test_task_command.py::TestCliTasks::test_task_states_for_dag_run
PASSED
[ 94%]
tests/cli/commands/test_task_command.py::TestCliTasks::test_test PASSED
[100%]
======================================================================================================================
warnings summary
======================================================================================================================
tests/cli/commands/test_task_command.py::TestCliTasks::test_cli_list_tasks
/usr/local/lib/python3.6/importlib/_bootstrap.py:219: RuntimeWarning:
numpy.ufunc size changed, may indicate binary incompatibility. Expected 192
from C header, got 216 from PyObject
return f(*args, **kwds)
tests/cli/commands/test_task_command.py::TestCliTasks::test_cli_list_tasks
/usr/local/lib/python3.6/site-packages/sqlalchemy/sql/sqltypes.py:271:
SAWarning: Unicode type received non-unicode bind param value "b'# -*- coding:
utf-8 -*-\\n#'...". (this warning may be suppressed after 10 occurrences)
(util.ellipses_string(value),),
tests/cli/commands/test_task_command.py::TestCliTasks::test_parentdag_downstream_clear
/opt/airflow/airflow/models/dag.py:1195: DeprecationWarning: This method
is deprecated and will be removed in a future version. Please use partial_subset
include_downstream=True,
-- Docs: https://docs.pytest.org/en/stable/warnings.html
==================================================================================================================
short test summary info
===================================================================================================================
SKIPPED [1] tests/conftest.py:313: The test is skipped because it has
quarantined marker. And --include-quarantined flag is passed to pytest.
<TestCaseFunction test_local_run>
===================================================================================================
16 passed, 1 skipped, 3 warnings in 165.93s (0:02:45)
====================================================================================================
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
