michalslowikowski00 commented on a change in pull request #12710:
URL: https://github.com/apache/airflow/pull/12710#discussion_r533956161
##########
File path: tests/providers/apache/spark/hooks/test_spark_sql.py
##########
@@ -213,3 +209,29 @@ def test_spark_process_runcmd_and_fail(self, mock_popen):
sql, master, params, status
),
)
+
+ def test_resolve_connection_yarn_default_connection(self):
+ hook = SparkSqlHook(conn_id='spark_default', sql='SELECT 1')
Review comment:
I would go even further and use
https://github.com/wolever/parameterized.
This is basically the same test case with different data
`expected_spark_connection` that can be parametrized thorough @parameterized().
Just saying. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
