[GitHub] [airflow] ashb commented on issue #4636: [AIRFLOW-3737] Kubernetes executor cannot handle long dag/task names

[GitBox]

ashb commented on issue #4636: [AIRFLOW-3737] Kubernetes executor cannot handle 
long dag/task names
URL: https://github.com/apache/airflow/pull/4636#issuecomment-475271004
 
 
   Both those changes seem fine to make part of this PR.
   
   Could we also have an explicit non-randomised test too. Something like:
   
   ```python
   id = "my_dag_id"
   self.assertEqual(
       id,
       AirflowKubernetesScheduler._make_safe_label_value(id)
   )
   id = "my_dag_id_" + "a"*64
   self.assertEqual(
       "my_dag_id_" + "a"*49 + "-HASHERE", 
       AirflowKubernetesScheduler._make_safe_label_value(id)
   )
   ``` 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services