ashb commented on a change in pull request #4823: [AIRFLOW-3999] Remove all inline style URL: https://github.com/apache/airflow/pull/4823#discussion_r267891349
########## File path: airflow/www/static/css/_page_dags.scss ########## @@ -0,0 +1,46 @@ +/** +* Licensed to the Apache Software Foundation (ASF) under one +* or more contributor license agreements. See the NOTICE file +* distributed with this work for additional information +* regarding copyright ownership. The ASF licenses this file +* to you under the Apache License, Version 2.0 (the +* "License"); you may not use this file except in compliance +* with the License. You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, +* software distributed under the License is distributed on an +* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +* KIND, either express or implied. See the License for the +* specific language governing permissions and limitations +* under the License. +*/ + +.edit-dag { Review comment: 100% no to BEM. `.btn__price`: Button ("btn") Does Not Belong In The Class. That's like having `class="red"`. Css classes names should be semantic in meaning, not presentational. There are hundreds of ways of writing CSS and an article saying that each of them is the best and everything else is wrong. Specificity is an integral part of CSS. Let's use it, instead of working around it. Going back to the original comment: do these rules _need_ to be scoped to a single page, or can they just live in the main CSS bundle (in which case lets not have them in a file that implies they are specific to a single page) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
