XD-DENG commented on a change in pull request #4952: [AIRFLOW-4008] add envFrom
for Kubernetes Executor
URL: https://github.com/apache/airflow/pull/4952#discussion_r268014507
##########
File path: airflow/contrib/kubernetes/pod.py
##########
@@ -66,6 +66,16 @@ class Pod:
:type tolerations: list
:param security_context: A dict containing the security context for the pod
:type security_context: dict
+ :param security_context: A dict containing the security context for the pod
+ :type security_context: dict
+ :param env_from_configmap_ref: Any configMapRef for the pod to envFrom.
+ If more than one configMapRef is required,
provide a
Review comment:
Indentation here is incorrect. It will cause display issue in the final
documentation. The same issue for the a few following lines as well.
(seems this issue already exists in the earlier existing docstring of this
file... If you don't mind, possibly can fix them together?)
A correct one for your reference:
https://github.com/apache/airflow/blob/master/airflow/sensors/base_sensor_operator.py#L43-L44
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
