XD-DENG commented on a change in pull request #12816:
URL: https://github.com/apache/airflow/pull/12816#discussion_r536336595
##########
File path: tests/core/test_configuration.py
##########
@@ -375,6 +377,11 @@ def test_getsection(self):
test_conf.getsection('testsection'),
)
+ self.assertEqual(
+ OrderedDict([('key', 'value')]),
+ test_conf.getsection('new_section'),
+ )
+
Review comment:
May be a bit too picky:
but I think it's worthwhile adding one more assert for a section *only*
existing in `airflow_defaults`'s sections (and not existing in env var either).
In that case, we should expect an empty OrderedDict rather than `None`.
Just to ensure we cover all cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
