[
https://issues.apache.org/jira/browse/AIRFLOW-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16798895#comment-16798895
]
ASF GitHub Bot commented on AIRFLOW-4140:
-----------------------------------------
CatarinaSilva commented on pull request #4958: [AIRFLOW-4140] Fix pause/unpause
button
URL: https://github.com/apache/airflow/pull/4958
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
This PR fixes the dag_id passed when pausing/unpausing from the interface,
which now works without any error:
Error before fix:
No error after fix:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
I did not build unit tests since this was literaly a 1 line fix, but if this
is a must I can try to add some.
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
Not a new functionality
### Code Quality
- [ ] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Pause/unpause button not working
> --------------------------------
>
> Key: AIRFLOW-4140
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4140
> Project: Apache Airflow
> Issue Type: Bug
> Components: webserver
> Affects Versions: 1.10.2
> Reporter: Catarina Silva
> Assignee: Catarina Silva
> Priority: Minor
>
> When using the current version of v1-10-stable, and starting the webserver
> with the provided scripts in `{color:#333333}airflow/scripts/ci/kubernetes`
> the unpause/pause button does not working. Looking at the logs we see the
> following error:{color}
> {{{color:#333333}[2019-03-21 16:20:11,908] \{app.py:1761} ERROR - Exception
> on /paused [POST]
> Traceback (most recent call last):
> File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 2292, in
> wsgi_app
> response = self.full_dispatch_request()
> File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1815, in
> full_dispatch_request
> rv = self.handle_user_exception(e)
> File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1718, in
> handle_user_exception
> reraise(exc_type, exc_value, tb)
> File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1813, in
> full_dispatch_request
> rv = self.dispatch_request()
> File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1799, in
> dispatch_request
> return self.view_functions[rule.endpoint](**req.view_args)
> File
> "/usr/local/lib/python2.7/dist-packages/airflow/www_rbac/decorators.py", line
> 121, in wrapper
> return f(self, *args, **kwargs)
> File
> "/usr/local/lib/python2.7/dist-packages/flask_appbuilder/security/decorators.py",
> line 26, in wraps
> return f(self, *args, **kwargs)
> File
> "/usr/local/lib/python2.7/dist-packages/airflow/www_rbac/decorators.py", line
> 56, in wrapper
> return f(*args, **kwargs)
> File "/usr/local/lib/python2.7/dist-packages/airflow/utils/db.py", line 73,
> in wrapper
> return func(*args, **kwargs)
> File "/usr/local/lib/python2.7/dist-packages/airflow/www_rbac/views.py",
> line 1633, in paused
> orm_dag.is_paused = False
> AttributeError: 'NoneType' object has no attribute 'is_paused'{color}}}{{}}
>
> {color:#333333}Tracing it back it is possible to check that the request made
> to change the `is_paused` field of the dag is missing the required `dag_id`
> field. However this fiel is available for example in the dag link.{color}
> {color:#333333}Digging a bit further in the code, we found that this is a bug
> in the template, which provides the wrong value when building the page.{color}
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
