TobKed commented on a change in pull request #12814: URL: https://github.com/apache/airflow/pull/12814#discussion_r537734616
########## File path: tests/providers/apache/beam/hooks/test_beam.py ########## @@ -0,0 +1,233 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +import copy +import unittest +from unittest import mock +from unittest.mock import MagicMock + +from parameterized import parameterized + +from airflow.exceptions import AirflowException +from airflow.providers.apache.beam.hooks.beam import BeamHook, _BeamRunner + +PY_FILE = 'apache_beam.examples.wordcount' +JAR_FILE = 'unitest.jar' +JOB_CLASS = 'com.example.UnitTest' +PY_OPTIONS = ['-m'] +TEST_JOB_ID = 'test-job-id' + +DEFAULT_RUNNER = "DirectRunner" +BEAM_STRING = 'airflow.providers.apache.beam.hooks.beam.{}' +BEAM_VARIABLES_PY = {'output': 'gs://test/output', 'labels': {'foo': 'bar'}} +BEAM_VARIABLES_JAVA = { + 'output': 'gs://test/output', + 'labels': {'foo': 'bar'}, +} + +APACHE_BEAM_V_2_14_0_JAVA_SDK_LOG = f""""\ +Dataflow SDK version: 2.14.0 +Jun 15, 2020 2:57:28 PM org.apache.beam.runners.dataflow.DataflowRunner run +INFO: To access the Dataflow monitoring console, please navigate to https://console.cloud.google.com/dataflow\ +/jobsDetail/locations/europe-west3/jobs/{TEST_JOB_ID}?project=XXX +Submitted job: {TEST_JOB_ID} +Jun 15, 2020 2:57:28 PM org.apache.beam.runners.dataflow.DataflowRunner run +INFO: To cancel the job using the 'gcloud' tool, run: +> gcloud dataflow jobs --project=XXX cancel --region=europe-west3 {TEST_JOB_ID} +""" + + +class TestBeamHook(unittest.TestCase): + @mock.patch(BEAM_STRING.format('_BeamRunner')) + def test_start_python_pipeline(self, mock_runner): + hook = BeamHook(runner=DEFAULT_RUNNER) + wait_for_done = mock_runner.return_value.wait_for_done + + hook.start_python_pipeline( # pylint: disable=no-value-for-parameter + variables=copy.deepcopy(BEAM_VARIABLES_PY), + py_file=PY_FILE, + py_options=PY_OPTIONS, + ) + + expected_cmd = [ + "python3", + '-m', + PY_FILE, + f'--runner={DEFAULT_RUNNER}', + '--output=gs://test/output', + '--labels=foo=bar', + ] + mock_runner.assert_called_once_with(cmd=expected_cmd) + wait_for_done.assert_called_once_with() + + @parameterized.expand( + [ + ('default_to_python3', 'python3'), + ('major_version_2', 'python2'), + ('major_version_3', 'python3'), + ('minor_version', 'python3.6'), + ] + ) + @mock.patch(BEAM_STRING.format('_BeamRunner')) + def test_start_python_pipeline_with_custom_interpreter(self, _, py_interpreter, mock_runner): + hook = BeamHook(runner=DEFAULT_RUNNER) + wait_for_done = mock_runner.return_value.wait_for_done + + hook.start_python_pipeline( # pylint: disable=no-value-for-parameter + variables=copy.deepcopy(BEAM_VARIABLES_PY), + py_file=PY_FILE, + py_options=PY_OPTIONS, + py_interpreter=py_interpreter, + ) + + expected_cmd = [ + py_interpreter, + '-m', + PY_FILE, + f'--runner={DEFAULT_RUNNER}', + '--output=gs://test/output', + '--labels=foo=bar', + ] + mock_runner.assert_called_once_with(cmd=expected_cmd) + wait_for_done.assert_called_once_with() + + @parameterized.expand( + [ + (['foo-bar'], False), + (['foo-bar'], True), + ([], True), + ] + ) + @mock.patch(BEAM_STRING.format('prepare_virtualenv')) + @mock.patch(BEAM_STRING.format('_BeamRunner')) + def test_start_python_pipeline_with_non_empty_py_requirements_and_without_system_packages( + self, current_py_requirements, current_py_system_site_packages, mock_runner, mock_virtualenv + ): + hook = BeamHook(runner=DEFAULT_RUNNER) + wait_for_done = mock_runner.return_value.wait_for_done + mock_virtualenv.return_value = '/dummy_dir/bin/python' + + hook.start_python_pipeline( # pylint: disable=no-value-for-parameter + variables=copy.deepcopy(BEAM_VARIABLES_PY), + py_file=PY_FILE, + py_options=PY_OPTIONS, + py_requirements=current_py_requirements, + py_system_site_packages=current_py_system_site_packages, + ) + + expected_cmd = [ + '/dummy_dir/bin/python', + '-m', + PY_FILE, + f'--runner={DEFAULT_RUNNER}', + '--output=gs://test/output', + '--labels=foo=bar', + ] + mock_runner.assert_called_once_with(cmd=expected_cmd) + wait_for_done.assert_called_once_with() + mock_virtualenv.assert_called_once_with( + venv_directory=mock.ANY, + python_bin="python3", + system_site_packages=current_py_system_site_packages, + requirements=current_py_requirements, + ) + + @mock.patch(BEAM_STRING.format('_BeamRunner')) + def test_start_python_pipeline_with_empty_py_requirements_and_without_system_packages(self, mock_runner): + hook = BeamHook(runner=DEFAULT_RUNNER) + wait_for_done = mock_runner.return_value.wait_for_done + + with self.assertRaisesRegex(AirflowException, "Invalid method invocation."): + hook.start_python_pipeline( # pylint: disable=no-value-for-parameter + variables=copy.deepcopy(BEAM_VARIABLES_PY), + py_file=PY_FILE, + py_options=PY_OPTIONS, + py_requirements=[], + ) + + mock_runner.assert_not_called() + wait_for_done.assert_not_called() + + @mock.patch(BEAM_STRING.format('_BeamRunner')) + def test_start_java_pipeline(self, mock_runner): + hook = BeamHook(runner=DEFAULT_RUNNER) + wait_for_done = mock_runner.return_value.wait_for_done + + hook.start_java_pipeline( # pylint: disable=no-value-for-parameter + jar=JAR_FILE, + variables=copy.deepcopy(BEAM_VARIABLES_JAVA), + ) + + expected_cmd = [ + 'java', + '-jar', + JAR_FILE, + f'--runner={DEFAULT_RUNNER}', + '--output=gs://test/output', + '--labels={"foo":"bar"}', + ] + mock_runner.assert_called_once_with(cmd=expected_cmd) + wait_for_done.assert_called_once_with() + + @mock.patch(BEAM_STRING.format('_BeamRunner')) + def test_start_java_pipeline_with_job_class(self, mock_runner): + hook = BeamHook(runner=DEFAULT_RUNNER) + wait_for_done = mock_runner.return_value.wait_for_done + + hook.start_java_pipeline( # pylint: disable=no-value-for-parameter + jar=JAR_FILE, variables=copy.deepcopy(BEAM_VARIABLES_JAVA), job_class=JOB_CLASS + ) + + expected_cmd = [ + 'java', + '-cp', + JAR_FILE, + JOB_CLASS, + f'--runner={DEFAULT_RUNNER}', + '--output=gs://test/output', + '--labels={"foo":"bar"}', + ] + mock_runner.assert_called_once_with(cmd=expected_cmd) + wait_for_done.assert_called_once_with() + + +class TestDataflow(unittest.TestCase): Review comment: I found there is mistake in the title (should be `TestBeamRunner`) and it is purpose is to test `providers.apache.beam.hooks.beam._BeamRunner` which is responsible for proper executing command in subprocess, printing stdout/stderr to logs and and handling exit code. In other tests this class is mocked and if runner is Dataflow slightly different command runner will be used: `airflow.providers.google.cloud.hooks.dataflow._DataflowRunner.` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
