feng-tao commented on a change in pull request #4808: [AIRFLOW_3982] Update 
DagRun state based on its tasks rather than DAG's
URL: https://github.com/apache/airflow/pull/4808#discussion_r268379986
 
 

 ##########
 File path: tests/test_jobs.py
 ##########
 @@ -2428,6 +2428,24 @@ def test_dagrun_root_fail_unfinished(self):
         dr_state = dr.update_state()
         self.assertEqual(dr_state, State.RUNNING)
 
+    def test_dagrun_root_after_dagrun_unfinished(self):
+        """
+        DagRuns with one successful and one future root task -> SUCCESS
+        """
+        dag_id = 'test_dagrun_states_root_future'
+        dag = self.dagbag.get_dag(dag_id)
+        dag.clear()
+        scheduler = SchedulerJob(dag_id, num_runs=2)
+        # we can't use dag.run or evaluate_dagrun because it uses BackfillJob
+        # instead of SchedulerJob and BackfillJobs are allowed to not respect 
start dates
 
 Review comment:
   nit: you mean `unlike SchedulerJob and BackfillJobs are allowed to not 
respect start dates` ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to