XD-DENG opened a new pull request #12971: URL: https://github.com/apache/airflow/pull/12971
This is a change discussed long time back in https://github.com/apache/airflow/pull/3889#issuecomment-507635839 Currently, ONLY Admin role is allowed to view "Profile" page, and edit profile info or reset password there. All other roles will get "Access Denied" if they click this `Your Profile` button.   The ideal situation should be: - all (default) roles should be able to view their profile page. - all (default) roles should be able to edit their profile, only if the webserver is DB-based. - all (default) roles should be able to reset their password, only if the webserver is DB-based. (For example, if the webserver is using LDAP or OAuth, users should NOT be allowed to edit their profile or reset password.) Essentially, the 7 permission-resource pairs are added for all default roles: - `can_this_form_post` on `UserInfoEditView` - `can_this_form_get` on `UserInfoEditView` - `can_userinfo` on `UserDBModelView` - `userinfoedit` on `UserDBModelView` - `can_this_form_post` on `ResetMyPasswordView` - `can_this_form_get` on `ResetMyPasswordView` - `resetmypassword` on `UserDBModelView` In addition, `can_userinfo` are added for all other possible User ModelViews (`UserOIDModelView`, `UserLDAPModelView`, `UserOAuthModelView`, and `UserRemoteUserModelView`. [Reference](https://flask-appbuilder.readthedocs.io/en/latest/security.html)) <!-- Thank you for contributing! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! In case of existing issue, reference it using one of the following: closes: #ISSUE related: #ISSUE How to write a good git commit message: http://chris.beams.io/posts/git-commit/ --> --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information. In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
