potiuk edited a comment on pull request #12967:
URL: https://github.com/apache/airflow/pull/12967#issuecomment-742444756


   Unfortunately there is no specs of the build environment so I am not sure 
which bash version it is :( . Will add it in fixup to dump this information ;) 
: https://docs.docker.com/docker-hub/builds/
   
   > Given docker hub auto builds are essentially another CI system, do we 
actually want the auto builds there, or would it be better to have builds be 
done in GH Actions and pushed to Docker hub (and perhaps, also to quay.io or 
some other registry.)
   
   I think there is a big advantage of using the auto-builds - they do not 
require authentication for image pushing. They all run in the dockerhub 
environment and the are 'pull' builds based on branch/tags pushed to the repo. 
While we know we can setup our secrets without INFRA now, I think not having to 
define and keep such secrets is an advantage on its own. 
   
   And according to INFRA all apache projects are excluded from the new "pull" 
policy. And this is still default source of images out there, so I think the 
limited way we are using it (just for Breeze CI image and to share production 
images) now is good.
   
   We could potentially switch to the new Github Registry. Unlike our current 
legacy registry we use for caching images, it supports anonymous image pulling 
for public images and we would not have to keep separate secrets. And I am 
quite sure we will eventually get there. But for that INFRA is still discussing 
whether to enable (and how to manage access) and it will likely require some 
changes for GitHub to support "per project maintainers" access level to write 
images - which is currently missing.
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to