mans2singh edited a comment on issue #4887: [AIRFLOW-4055] Add AWS SQS Sensor URL: https://github.com/apache/airflow/pull/4887#issuecomment-475895414 @zhongjiajie - Thanks for your comments. I generally try to keep conditions separate so that they can log specific messages for easy debugging. I was also using a try block is so that I can log the exception and then propagate it. But I agree with your feedback and that it makes the code more concise and have made the recommended changes. I am not sure of what would be an intuitive name for the sqs sensor. I was thinking that sensor will indicate it subscribes to sqs. But if SQSPushXComSensor/SQSPushSensor or any other name is more expressive, please let me know. Thanks again for your time and advice.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
