ad-m commented on a change in pull request #13187:
URL: https://github.com/apache/airflow/pull/13187#discussion_r546363526
##########
File path: airflow/providers/amazon/aws/hooks/s3.py
##########
@@ -515,6 +515,7 @@ def load_string(
encrypt: bool = False,
encoding: Optional[str] = None,
acl_policy: Optional[str] = None,
+ gzip: bool = False,
Review comment:
I am not questioning the choice of the gzip algorithm. It is now
standard and popular. I wonder if adding the "gzip" parameter instead of - for
example - "compression" (enum with value "gzip") will not make this operator
have many parameters in the future when more algorithm might be added. See for
example at
https://github.com/apache/airflow/blob/349b0811c3022605426ba57d30936240a7c2848a/airflow/providers/google/cloud/transfers/bigquery_to_gcs.py#L47-L48
regarding future-proof `compression` parameter.
I would like to point out that your experience with Airflow is definitely
much greater than mine. I mainly observe and comment on the project from time
to time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
