potiuk commented on a change in pull request #13156:
URL: https://github.com/apache/airflow/pull/13156#discussion_r546856753
##########
File path: tests/providers/google/cloud/hooks/test_gcs.py
##########
@@ -672,7 +672,7 @@ def test_download_to_file(self, mock_service):
)
self.assertEqual(response, test_file)
- download_filename_method.assert_called_once_with(test_file)
+ download_filename_method.assert_called_once_with(test_file, timeout=60)
Review comment:
I think it's good to have them hard-coded :).
the tests should be DAMP rather than DRY
https://stackoverflow.com/questions/6453235/what-does-damp-not-dry-mean-when-talking-about-unit-tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
