XD-DENG commented on a change in pull request #13232:
URL: https://github.com/apache/airflow/pull/13232#discussion_r546911935
##########
File path: airflow/utils/cli.py
##########
@@ -227,8 +227,12 @@ def setup_locations(process, pid=None, stdout=None,
stderr=None, log=None):
stdout = os.path.join(settings.AIRFLOW_HOME, f'airflow-{process}.out')
if not log:
log = os.path.join(settings.AIRFLOW_HOME, f'airflow-{process}.log')
+
if not pid:
pid = os.path.join(settings.AIRFLOW_HOME, f'airflow-{process}.pid')
+ else:
+ if not os.path.isabs(pid):
+ raise AirflowException("Path of PID file must be absolute")
Review comment:
My personal preference aligns with your suggestion.
The current implementation is a "mid-point agreed" after the discussion. Or
we should further elaborate the discussion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
