houqp commented on a change in pull request #13278:
URL: https://github.com/apache/airflow/pull/13278#discussion_r548275287
##########
File path: airflow/utils/types.py
##########
@@ -16,8 +16,31 @@
# under the License.
import enum
+from sqlalchemy.types import TypeDecorator, String
-class DagRunType(str, enum.Enum):
+
+class EnumString(TypeDecorator):
+ """
+ Declare db column with this type to make the column compatible with string
+ and string based enum values when building the sqlalchemy ORM query. It can
+ be used just like sqlalchemy.types.String, for example:
+
+ ```
+ class Table(Base):
+ __tablename__ = "t"
+ run_type = Column(EnumString(50), nullable=False)
+ ```
+ """
+ impl = String
+
+ def process_bind_param(self, value, dialect):
+ if isinstance(value, enum.Enum):
+ return value.value
+ else:
+ return value
+
+
+class DagRunType(enum.Enum):
Review comment:
How did you perform the mysql test? You should be able to reproduce the
problem with my newly added test case in breeze.
I am open to better way to handle this as well, but I think whatever
solution we end up with, we should aim for consistent behavior between db
drivers.
IMHO, i think it's not a bad idea to use `DagRunType.SCHEDULED.value`
through out the code base. This leads to less magic/abstraction, which will
make the code easier to follow and maintain. It will also reduce chances of us
running into subtle bugs like this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
